Add agent panel font family settings - #59629
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @lholden on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
fb944f3 to
9657774
Compare
|
Thanks for this! Unfortunately, I will close this at this time: Please see our repository contribution guidelines for more context, but I think this PR would warrant a discussion first - code-wise this looks very good, but for the configuration this adds, we'd first like to see whether there is actual demand for this, which (at least so far) does not seem to be the case. Will close with this, but feel free to open a discussion/find and link one and we might eventually go with this. Thanks! |
I understand, if unfortunate. This has been one of those things I've been wanting for a while. I generally like having a monospace font for my agents output, but right now in Zed the only way to do so at present is to set the entire UI to using a monospace font... which looks bad. But I can add/find a feature request in the discussions. |
MrSubidubi
left a comment
There was a problem hiding this comment.
That is enough traction for me to warrant this and we also have it for the markdown preview nowadays, so let's go with it. Thank you!
|
@MrSubidubi this PR has a regression: 
The ui elements use the same font size as the agent response font size. When they should actually follow the global ui font size for consistency. It doesn't make sense why these drop-downs should become bigger, when the point of the PR is to change the font and size of the agent responses. The pr also does not let us set a monospaced font for inline code. I believe #61672 takes both of these issues into consideration. Would you like me to make a PR fixing this, I could also just redo my other PR with a tighter scope focusing just on the agent panel fonts. |
|
@0arm Thanks for spotting this, feel free to open a follow-up PR |
Objective: Allow users to configure the font families used by agent panel content separately from the main UI and buffer fonts. Solution: - Add `agent_ui_font_family` for agent responses in the agent panel. - Add `agent_buffer_font_family` for the agent panel message editor and user messages. - Keep context menus on the primary UI font family. - Document the new settings and expose them in the settings UI. Testing: - Ran `cargo fmt`. - Ran `cargo check -p settings_content -p theme_settings -p markdown -p agent_ui -p settings_ui -p ui`. - Ran `git diff --check`. - Manually tested the agent panel font behavior in a dev build. Release Notes: - Added settings for configuring agent panel UI and buffer font families. Co-authored-by: Finn Evers <finn@zed.dev>
Objective:
Allow users to configure the font families used by agent panel content separately from the main UI and buffer fonts.
Solution:
agent_ui_font_familyfor agent responses in the agent panel.agent_buffer_font_familyfor the agent panel message editor and user messages.Testing:
cargo fmt.cargo check -p settings_content -p theme_settings -p markdown -p agent_ui -p settings_ui -p ui.git diff --check.Release Notes: