terminal_view: Show terminal inline assist keybinding in tooltip - #55903
Merged
smitbarmase merged 3 commits intoJul 3, 2026
Merged
Conversation
di404
marked this pull request as ready for review
May 6, 2026 16:49
smitbarmase
approved these changes
Jul 3, 2026
smitbarmase
left a comment
Member
There was a problem hiding this comment.
Thanks! I made two changes on top. Clicking the inline assist button did nothing since we were recreating the button entity on every render, so turned that to RenderOnce component. Also added a test.
smitbarmase
enabled auto-merge
July 3, 2026 13:44
TakuroBreath
pushed a commit
to TakuroBreath/zed
that referenced
this pull request
Jul 7, 2026
…-industries#55903) ## Summary - Fixed the terminal inline assist tab bar tooltip so it resolves the keybinding from the active terminal view. - The bug happened when the initial terminal was closed and a new terminal was opened: the tab bar button kept a cached focus handle for the old terminal, so tooltip keybinding lookup could no longer find the terminal key context. - The button is now created while rendering the tab bar with the current terminal view's focus handle, avoiding stale focus handles as terminals are closed and recreated. ## Validation - `cargo fmt --package terminal_view --check` - `cargo check -p terminal_view --message-format short` Release Notes: - Fixed the terminal inline assist toolbar tooltip not showing its keybinding after reopening terminals. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…-industries#55903) ## Summary - Fixed the terminal inline assist tab bar tooltip so it resolves the keybinding from the active terminal view. - The bug happened when the initial terminal was closed and a new terminal was opened: the tab bar button kept a cached focus handle for the old terminal, so tooltip keybinding lookup could no longer find the terminal key context. - The button is now created while rendering the tab bar with the current terminal view's focus handle, avoiding stale focus handles as terminals are closed and recreated. ## Validation - `cargo fmt --package terminal_view --check` - `cargo check -p terminal_view --message-format short` Release Notes: - Fixed the terminal inline assist toolbar tooltip not showing its keybinding after reopening terminals. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt --package terminal_view --checkcargo check -p terminal_view --message-format shortRelease Notes: