Skip to content

Move testing libraries into devDeps rather than peerDeps for base package - #4029

Open
walshie4 wants to merge 2 commits into
react-native-elements:nextfrom
walshie4:remove-jest-peer-dep
Open

Move testing libraries into devDeps rather than peerDeps for base package#4029
walshie4 wants to merge 2 commits into
react-native-elements:nextfrom
walshie4:remove-jest-peer-dep

Conversation

@walshie4

@walshie4 walshie4 commented Apr 8, 2026

Copy link
Copy Markdown

Motivation

Fixes #4022

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Not really relevant as it is simply removing a peer dependency that should never have been there.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

See the linked issue

@walshie4 walshie4 mentioned this pull request Apr 8, 2026
Open
1 task
@Tiuipuv

Tiuipuv commented Apr 8, 2026

Copy link
Copy Markdown

Hope this gains traction! Looking forward to the merge so we can remove --legacy-peer-deps from our pipelines.

@AlixH

AlixH commented Apr 29, 2026

Copy link
Copy Markdown

Up :)

@theianmay
theianmay self-requested a review June 21, 2026 17:01
@theianmay theianmay self-assigned this Jun 21, 2026
@emoreno-94

emoreno-94 commented Jun 25, 2026

Copy link
Copy Markdown

up

@mduchev

mduchev commented Jul 8, 2026

Copy link
Copy Markdown

Any progress on this?

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.40%. Comparing base (e774673) to head (d0071e3).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #4029   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files          90       90           
  Lines        2141     2141           
  Branches      954      919   -35     
=======================================
  Hits         1700     1700           
  Misses        439      439           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theianmay theianmay Awaiting requested review from theianmay

Assignees

@theianmay theianmay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@testing-library/jest-native + @testing-library/react-native in peerDependencies (v5)

6 participants

@walshie4 @Tiuipuv @AlixH @emoreno-94 @mduchev @theianmay