Skip to content

Add AntDesign to icons in src/helps/getIconType.js - #1529

Merged
iRoachie merged 12 commits into
react-native-elements:nextfrom
osdnk:patch-1
Oct 31, 2018
Merged

Add AntDesign to icons in src/helps/getIconType.js#1529
iRoachie merged 12 commits into
react-native-elements:nextfrom
osdnk:patch-1

Conversation

@osdnk

@osdnk osdnk commented Oct 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Base on: https://github.com/react-native-training/react-native-elements/pull/1474

Motivation

Wish to use new icon set from RNVI

Changes

Add proper import and bump RNVI version

@osdnk

osdnk commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

cc @d-p-s @iRoachie

iRoachie
iRoachie requested changes Oct 30, 2018
View reviewed changes

@iRoachie iRoachie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @osdnk thanks for submitting.

Just a few things left to do:

@iRoachie

iRoachie commented Oct 30, 2018

Copy link
Copy Markdown
Collaborator

Also add it to the list of icons here https://github.com/react-native-training/react-native-elements/blob/next/docs/icon.md#available-icon-sets

@iRoachie iRoachie mentioned this pull request Oct 30, 2018
Closed
@osdnk

osdnk commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

Ok, I'll do it soon

@codecov

codecov Bot commented Oct 30, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1529 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1529   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files          33       33           
  Lines         612      612           
  Branches       85       85           
=======================================
  Hits          462      462           
  Misses        129      129           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fbebc...9f5174f. Read the comment docs.

@osdnk

osdnk commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

@iRoachie
Please take a look

iRoachie
iRoachie reviewed Oct 30, 2018
View reviewed changes
Comment thread docs/icon.md Outdated
@iRoachie @osdnk
Update docs/icon.md
9f5174f 
Co-Authored-By: osdnk <micosa97@gmail.com>
@osdnk

osdnk commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

Done

@iRoachie

iRoachie commented Oct 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Lastly could you do a rebase from the next branch? Seems you have some unwanted commits.

@osdnk

osdnk commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

I could do it tommorow. Wouldn't you like simply squash my commits?

@iRoachie

iRoachie commented Oct 31, 2018

Copy link
Copy Markdown
Collaborator

Nvmd it's fine.

@iRoachie
iRoachie merged commit 83a8625 into react-native-elements:next Oct 31, 2018
@iRoachie

iRoachie commented Oct 31, 2018

Copy link
Copy Markdown
Collaborator

Thanks for pulling this off 💯 Great job

@iRoachie

iRoachie commented Oct 31, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

We may actually have to delay this a bit, AntDesign isn't available through expo, and it throws an error.

@osdnk

osdnk commented Oct 31, 2018

Copy link
Copy Markdown
Contributor Author

@iRoachie
I have contacted with Expo team and they do confirm that it will be available in a new release (31.0.0), which will be available soon (it's matter of few days)
CC: @tsapeta

@iRoachie

iRoachie commented Oct 31, 2018

Copy link
Copy Markdown
Collaborator

Thanks!

nurdiansyah added a commit to deboxlibrary/react-native-elements that referenced this pull request Nov 6, 2018
@nurdiansyah
Merge commit '0126436f5f0f37e0340b0c1da32bdea5605cb6df'
6a921b4 
* commit '0126436f5f0f37e0340b0c1da32bdea5605cb6df': (43 commits)
  feat(Card): Remove flexDirection prop
  feat(Card): Remove fontFamily prop
  test: Add tests for withTheme
  test: Fix searcbar error being logged to console
  fix: Hoist statics for withTheme hoc (react-native-elements#1554)
  fix: Use library for calculating statusBar height (react-native-elements#1553)
  ref: Badge component (react-native-elements#1545)
  Set default prop for type (react-native-elements#1546)
  docs: Fix paragraphs links in docs (react-native-elements#1536)
  docs(website): Make image preview section reusable
  feat: Add button types (react-native-elements#1540)
  fix: Rounded buttons on android now work correctly (react-native-elements#1538)
  ci: Run travis against node stable
  fix: Make button height consistent when using loading
  ci: Update husky and lint-staged
  feat: Add AntDesign to list of available icon sets (react-native-elements#1529)
  docs(website): Add central place to show supported icon sets (react-native-elements#1532)
  feat(Input): Allow label to be a React element (react-native-elements#1531)
  ci: Remove expo ci from PRs (react-native-elements#1528)
  fix(Button): Make the padding consistent (react-native-elements#1505)
  ...
@iRoachie iRoachie mentioned this pull request Nov 12, 2018
Closed
@Monte9

Monte9 commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

This fixed it for me: yarn add @expo/vector-icons

expo/expo#1083 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iRoachie iRoachie iRoachie approved these changes

Assignees

No one assigned

Labels

✨ Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@osdnk @iRoachie @Monte9 @d-p-s