Refactor PriceCard props to accept style objects - #1231
Merged
Conversation
Gregjarvez
force-pushed
the
refactor-priceitem-props
branch
from
May 26, 2018 00:01
61691f9 to
ecd726f
Compare
Collaborator
|
Example app for the last commit (e2808d5): |
Codecov Report
@@ Coverage Diff @@
## next #1231 +/- ##
=======================================
Coverage 71.13% 71.13%
=======================================
Files 33 33
Lines 589 589
Branches 88 88
=======================================
Hits 419 419
Misses 142 142
Partials 28 28
Continue to review full report at Codecov.
|
iRoachie
reviewed
May 28, 2018
iRoachie
left a comment
Collaborator
There was a problem hiding this comment.
Sweeet 💯. Just need to update the docs and the typescript definitions.
Gregjarvez
force-pushed
the
refactor-priceitem-props
branch
from
May 29, 2018 19:31
ecd726f to
bad9ab6
Compare
iRoachie
requested changes
May 30, 2018
Gregjarvez
force-pushed
the
refactor-priceitem-props
branch
from
May 31, 2018 15:51
bad9ab6 to
e2808d5
Compare
iRoachie
approved these changes
May 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1212