perf: Cache normalisedColors output - #57896
Open
riteshshukla04 wants to merge 4 commits into
Open
Conversation
Contributor
|
CI is failing for android. I don't think it is due to your changes. |
cipolleschi
reviewed
Aug 11, 2026
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
thanks for improving this.
Contributor
Author
|
@cipolleschi I fixed all issues . The iOS pipeline fail looks like network flake . |
Contributor
Author
|
Update: I re triggered CI with empty commit 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While looking into something I saw this processColor function , for every color we are calculating normalise Color even though it would have been done earlier.
This is a simple approach. Maybe we can add things like LRU. With some simple scripts(Rendering around 1000 cells) I found around 13% faster .
Changelog:
[GENERAL][FIXED] - use cached results for already normalised colors
Test Plan:
Tested in RN tester.