JSX: Allow apostrophes in element text (#2816) - #3214
Merged
Conversation
JSX child text falls through to the inherited JavaScript rules, where an apostrophe is not a valid standalone token and becomes an Error token. Treat unmatched apostrophes as text after inherited string rules, preserving normal JavaScript and TypeScript strings. Add golden regression coverage. Fixes pygments#2816
Member
|
Thank you! |
Contributor
|
@Sanjays2402 thank you for this fix, too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSX element text currently falls through to the inherited JavaScript rules, so an apostrophe in a contraction becomes an
Errortoken and strict consumers such as Sphinx reject valid JSX. This adds a text fallback after normal JavaScript and TypeScript string handling, with a golden regression fixture.Fixes #2816