Vala: recognize conditional compilation directives - #3207
Merged
birkenfeld merged 1 commit intoJul 14, 2026
Conversation
The lexer only handled the special `#if 0` case, so valid `#if`, `#elif`, `#else`, and `#endif` lines emitted Error tokens for their hash marks. Recognize complete conditional-directive lines as preprocessor comments and add a golden regression snippet based on the report. Fixes pygments#2858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vala lexer only special-cased
#if 0, so valid#if,#elif,#else, and#endiflines emittedErrortokens for#. This recognizes those lines as preprocessor directives and adds a golden regression snippet based on the report.Fixes #2858.