fix(tray): scroll to top in the activity window on opening - #10533
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88ef7e23a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d543522c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| positionAtEnd(); | ||
|
|
||
| activitiesWindow.resetActivityList(); |
There was a problem hiding this comment.
Exercise the already-visible Systray reopen path
When the activities window is already visible—the scenario requiring the new queued invocation in Systray::showActivitiesWindow()—this test calls resetActivityList() directly, so it remains green if that C++ invocation is removed or broken and the stale scroll offset returns. Exercise the reopen operation through Systray or an equivalent integration seam so the regression test covers the original failure path.
AGENTS.md reference: AGENTS.md:L205-L209
Useful? React with 👍 / 👎.
- reopening will ensure tha the list is scrolled to the top - before, the scroll location was memorized and and new notifications or conflicts were missed Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
…resources and registers the production SVG image provider Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
7458c8c to
2f96fe9
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10533.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Assisted-by: Codex:GPT-5