Add Uptime kuma community container - #8495
Conversation
see nextcloud/all-in-one#8495 Signed-off-by: derStephan <derStephan@users.noreply.github.com>
szaimen
left a comment
There was a problem hiding this comment.
Hi, I am not really sure about this. See #7082 (reply in thread)
|
I answered there. |
Removing my comment so that @pablo can decide on this
2e734d9 to
bbc9df8
Compare
Signed-off-by: derStephan <derStephan@users.noreply.github.com>
Signed-off-by: derStephan <derStephan@users.noreply.github.com>
adds distinction to glances Signed-off-by: derStephan <derStephan@users.noreply.github.com>
Signed-off-by: derStephan <derStephan@users.noreply.github.com>
|
@derStephan Thank you for your first PR! 馃憦 I think it's a nice idea to integrate a full, standalone monitoring tool like this, and would prefer it over tools like "upptime" that rely on github.com. My main problem with this is the integration of the docker socket, because it is such a gaping security boundary violation waiting to be exploited. I know some other community containers are using it, too, and I'm unhappy with that, and at least would like to not allow even more containers to use it. From my perspective this would also be useful without the docker socket. It would require more configuration work, and provide less details automatically, but that's the price for better security protection, I'd say. @derStephan Do you think you could change the integration to work like that? For Nextcloud there's e.g. Apart from this fundamental issue I'd have a few smaller remarks, which I'll hold back until we found a common ground. |
|
@pabzm Thank you for your thoughts. I generally agree that this can be a security issue. However, it only allows read-only access to the socket. And without that, it is still useful for remote servers but not for the internal health documentation. Glances container is using this socket as well because without it, it will be useless. The status.php requires a running nextcloud and will not alert in cases like #8437. I can put a fat warning in the readme - as I did for the downtime during backups. Then the actual user can decide. |
Signed-off-by: derStephan <derStephan@users.noreply.github.com>
|
done. |
This is my very first attempt for creating a community container. I will add another PR to integrate that into caddy.
Summary
3. to review, feature component)AI (if applicable)