Dedent configured pathspec patterns - #4155
Open
ishaanlabs-gg wants to merge 1 commit into
Open
Conversation
Author
|
The remaining CI failures appear unrelated to this patch and happen before MkDocs tests run:
All CPython test jobs, style, lint, docs build, and package checks passed for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathSpecconfig values before compiling them as gitignore-style patterns.This fixes the current
draft_docsbehavior where indented examples such as the user-guide-style config no longer match paths with newerpathspec.Tests
python -m unittest mkdocs.tests.config.config_options_tests.PathSpecTest.test_indented_multiline_patternspython -m unittest mkdocs.tests.build_tests.BuildTests.test_draft_docs_with_comments_from_user_guidepython -m compileall -q mkdocs/config/config_options.py mkdocs/tests/config/config_options_tests.pygit diff --checkAI assistance was used to help prepare this change.