Core: Validate inputs with duplicate name / name[] arrays, instead of just the first item - #2498
Open
bompus wants to merge 2 commits into
Open
Core: Validate inputs with duplicate name / name[] arrays, instead of just the first item#2498bompus wants to merge 2 commits into
bompus wants to merge 2 commits into
Conversation
KES777
reviewed
Jan 26, 2025
Comment on lines
+462
to
+469
| var type = element.attr( "type" ); | ||
| if ( type === 'checkbox' || type === 'radio' ) { | ||
| // only check the first checkbox/radio input ( https://github.com/jquery-validation/jquery-validation/pull/2431#issuecomment-1172835268 ) | ||
| if ( element.name in checkedCache ) { | ||
| continue; | ||
| } | ||
| checkedCache[ element.name ] = true; | ||
| } |
There was a problem hiding this comment.
This is not clear why we check only first checkbox?
What about the cases when we ask user to check boxes which labels does not have a letter?
Comment on lines
-660
to
+675
| // Select only the first element for each name, and only those with rules specified | ||
| if ( name in rulesCache || !validator.objectLength( $( this ).rules() ) ) { | ||
| if ( name in rulesCache ) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Actually this is correct, that we do not allow elements with the same name. I believe this is by RFC. Though I could be wrong, because I did not work with checkbox/radio a lot.
|
@bytestream I am not familiar with checkbox/radio input types, but it looks like they try to resolve a different problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces #2000 and #2431 with simpler logic, and I believe that .elements() should return all of the eligible elements.
Previously, if you had 2+ inputs using name arrays, such as:
It would only hit validation on the first input in the array, allowing all the remaining inputs with the same name to remain empty.
Technically, I'm pretty sure the following, without using [] syntax would have the same problem:
I'm not familiar with the testing framework, but please review the idea behind this PR first, and if you're confident that it will be merged if tests are included, I'll dig deeper into testing.