Filter Kotlin 2.5.0 throwNoWhenBranchMatchedException bytecode - #2249
Open
arimu1 wants to merge 1 commit into
Open
Filter Kotlin 2.5.0 throwNoWhenBranchMatchedException bytecode#2249arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
Kotlin 2.5.0 generates an exhaustive when default branch via throwNoWhenBranchMatchedException + KotlinNothingValueException instead of constructing NoWhenBranchMatchedException directly. Extend KotlinWhenFilter to recognize both patterns. Fixes jacoco#2216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kotlin 2.5.0 changed the bytecode generated for the implicit default branch of exhaustive
whenexpressions/statements: instead of constructingNoWhenBranchMatchedExceptiondirectly, the compiler loads the subject and callskotlin.internal.throwNoWhenBranchMatchedException, then throwsKotlinNothingValueException(see JetBrains/kotlin@d3fba8a and JetBrains/kotlin@0562bdb).This extends
KotlinWhenFilterso it still recognizes and filters that implicit default branch, while keeping support for the pre-2.5.0 pattern.Related issue
Fixes #2216
How to test
All 9
KotlinWhenFilterTestcases pass (existing patterns + three new Kotlin 2.5.0 cases for implicit else, implicit default switch, and nullable enum without else).