fix(ci): skip unknown labels in issue labeler instead of failing - #14426
Open
erensh27 wants to merge 1 commit into
Open
fix(ci): skip unknown labels in issue labeler instead of failing#14426erensh27 wants to merge 1 commit into
erensh27 wants to merge 1 commit into
Conversation
The labeler LLM is told to pick from a fixed set of labels, but several of those labels do not exist in the repo (e.g. 'compile', 'attention-backends', 'torchao', 'new-pipeline/model'). Applying any of them with 'gh issue edit --add-label' fails the whole job, so most bug reports end up with no labels at all (issue huggingface#14377: 'needs-env-info'). Filter the model output against the repo's actual label list before applying, and emit a warning for any label that does not exist instead of failing the run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14377.
The labeler LLM is told to pick from a fixed set of labels, but several of those labels do not exist in the repo (
compile,attention-backends,torchao,new-pipeline/modelare still missing today;needs-env-infohas since been created).gh issue edit --add-labelfails for any non-existent label, aborting the whole job and leaving most bug reports unlabeled.Fix (
.github/workflows/issue_labeler.yml): fetch the repo's current label list and only apply labels that exist, skipping the rest with an explicit::warningin the run log. The job no longer fails on label drift, and the warning makes missing labels visible so they can be created.Note:
utils/label_issues.pystill declares the four missing labels as valid — they may be created later; the workflow filter keeps things working either way.