fix(caretaker-agent): use spec-valid names for two triage-worker skills - #28742
fix(caretaker-agent): use spec-valid names for two triage-worker skills#28742bechor25 wants to merge 1 commit into
Conversation
`code_explorer` and `spec_generator` contain underscores, which the Agent Skills spec does not allow in the `name` field — only lowercase alphanumerics and hyphens. `skills-ref validate` rejects both. The other two skills in the same directory, `effort` and `quality`, are already valid, so this brings the set in line with itself. Renamed the field and the directory for each (the spec also requires the name to match its parent directory), plus the three invocations in .gemini/triage_orchestrator.md that address the skills by name. `git grep` for either old name now returns nothing. Spec: https://agentskills.io/specification#name-field
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a non-compliance issue where two agent skills contained underscores in their names, violating the Agent Skills specification. By renaming these skills and updating their associated directory paths and internal references, the changes ensure that the skills are correctly validated and registered by the system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/S
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request renames the code_explorer and spec_generator skills to code-explorer and spec-generator respectively, updating both their definition files and the orchestrator markdown file to use hyphens instead of underscores. There are no review comments, and I have no additional feedback to provide.
Note: Security Review has been skipped due to the limited scope of the PR.
What
Two of the four skills under
tools/caretaker-agent/cloudrun/triage-worker/.gemini/skills/use underscores in theirname:Why it matters
The Agent Skills specification constrains the
namefield:Underscores are outside that set, so
skills-ref validaterejects both skills and a strict loader can refuse to register them.The set is already inconsistent with itself
name:efforteffortqualityqualitycode_explorercode_explorerspec_generatorspec_generatorThe change
For each of the two skills, the
namefield and its directory are renamed together, so the name stays valid and keeps matching its parent directory:code_explorer→code-explorerspec_generator→spec-generatorBoth skills are invoked by name from
.gemini/triage_orchestrator.md, so those three references are updated in the same commit.git grep code_explorerandgit grep spec_generatorboth return nothing afterwards.Found with AgentCompass, an offline static analyzer for AI-agent repo readiness. Verified by hand against the spec before opening.