Fix recursive outer nested loop join state reuse - #24700
Open
kryonix wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recursive CTE containing a
FULLorRIGHTouter nested loop join could fail when the recursive executor reused its local source state. Assertion builds failed while initializing an already initialized scan chunk, while release builds could retain duplicate vectors and eventually access them out of bounds.The local source reset path was calling
OuterJoinMarker::InitializeScanon every recursive iteration. That function performs one-time initialization of the scan chunk, so calling it again violated the chunk lifecycle.I moved that initialization into the nested loop join local scan state constructor. Reusing the state now resets the existing chunk and replaces its scan bookkeeping without reconstructing its schema or vector cache. This preserves recursive state reuse while giving each iteration a clean outer-join scan.
Fixes duckdb/duckdb-fuzzer#4635.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/9824.