fix(paste): respect tool sanitize config for paste tags (Fixes #2984) - #3019
Open
waterWang wants to merge 1 commit into
Open
fix(paste): respect tool sanitize config for paste tags (Fixes #2984)#3019waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
waterWang
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
August 11, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2984 —
pasteConfigignores tool'ssanitizerules.Problem
When pasting HTML content, the paste module builds its sanitizer config only from the tool's
pasteConfig.tags. When a tool declares its tags as plain strings (e.g.tags: ['P', 'DIV']), thesanitizationConfigfor each tag isnull, and the code falls back to{}— stripping all attributes from pasted elements.Meanwhile the tool's
static get sanitize()explicitly allows certain attributes (e.g.p: { style: true }). These rules are ignored during paste, so pasting from Google Docs loses paragraph indentation and other inline styles.Fix
In
Paste.processDataTransfer, when a tag has no explicit sanitization config frompasteConfig.tags, fall back to the tool'ssanitizeConfigrules for that tag. Only if neither provides a rule do we strip all attributes.Reproduction
Before: pasted
<p style="text-indent: 36pt;">becomes<p><span>...</span></p>(style stripped)After: pasted
<p style="text-indent: 36pt;">is delivered to the tool with itsstyleattribute preserved.Checklist
vite build)