Add opt-in cleanup for failed releases - #2186
Open
YukiJikumaru wants to merge 1 commit into
Open
Conversation
Add a :remove_failed_release setting, defaulting to false, to remove a failed release_path after deploy:failed. Skip removal when current resolves to the same release. Document the setting and add Cucumber coverage for the default behavior, enabled cleanup, and preserving the current release. Refs capistrano#2120. Refs capistrano#1907.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in
:remove_failed_releasesetting, defaulting tofalse, to remove a failedrelease_pathafterdeploy:failed.This helps prevent failed release directories from consuming
:keep_releasesslots and causing older working releases to be cleaned up. The cleanup is conservative: Capistrano skips removal whencurrentresolves to the same release, preserving a release that has already been published.This PR also documents the new setting and adds Cucumber coverage for:
Refs #2120.
Refs #1907.
Short checklist
bundle exec rubocop -ato fix linter issues?Other Information
Verified locally with:
bundle exec cucumber features/remove_failed_release.featurebundle exec rake rubocopbundle exec rake spec