[ZEPPELIN-6451] Add default NotebookRepo settings methods to remove duplicated placeholder implementations - #5411
Open
Coen90 wants to merge 1 commit into
Conversation
…uplicated placeholder implementations
jongyoul
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Several
NotebookRepoimplementations (S3, GCS, OSS, Azure, Mongo, FileSystem, InMemory) duplicated the same placeholder code forgetSettings/updateSettings— returning an empty list or logging "Method not implemented".This PR centralizes that placeholder behavior as
defaultmethods on theNotebookRepointerface:getSettingsreturns an empty list and logs at DEBUG level (querying settings is a normal read path, so it should not produce warning noise).updateSettingsis a no-op and logs at WARN level (an ignored update attempt is worth surfacing).All duplicated overrides are removed from the plugin repos,
InMemoryNotebookRepo, and the test helper repos inNotebookTest. Repos with real settings logic (e.g.VFSNotebookRepo,GitNotebookRepo) keep their own overrides and are unaffected. Since these aredefaultinterface methods, existing third-partyNotebookRepoimplementations remain source- and binary-compatible.What type of PR is it?
Refactoring
Todos
getSettings/updateSettingsimplementations toNotebookRepoWhat is the Jira issue?
How should this be tested?
zeppelin-servertest suite covers the affected code paths:./mvnw test -pl zeppelin-server -amScreenshots (if appropriate)
Questions:
defaultmethods keep existing implementations compatible; the only visible change is the log level/message of the placeholder behavior.