Skip to content

DYN-9321: Prevent adding CBN into collapsed annotation on double-click - #17282

Open
ivaylo-matov wants to merge 1 commit into
DynamoDS:masterfrom
ivaylo-matov:DYN-9321-When-minimize-the-group-and-add-a-CodeBlock-node-in-the-group-I-got-a-strange-behavior
Open

DYN-9321: Prevent adding CBN into collapsed annotation on double-click#17282
ivaylo-matov wants to merge 1 commit into
DynamoDS:masterfrom
ivaylo-matov:DYN-9321-When-minimize-the-group-and-add-a-CodeBlock-node-in-the-group-I-got-a-strange-behavior

Conversation

@ivaylo-matov

Copy link
Copy Markdown
Contributor

Purpose

This is a small PR to address DYN-9321

Fixes a bug where double-clicking a collapsed annotation would create a visible CodeBlock node that nevertheless became part of the collapsed group's model (causing layout/visibility/boundary glitches).

Now double-clicking an annotation still creates a CodeBlock node, but the node is only added to the annotation when the annotation is expanded (aligned with drag-to-group behavior).

Changes

  • WorkspaceViewModel.HandleAnnotationDoubleClick ensure newly created node is added to the annotation only when annotation.IsExpanded
  • regression test

Before:

DYN-9321-Before__

After:

DYN-9321-After__

Declarations

Check these if you believe they are true

Release Notes

Prevent newly created Code Block nodes from being added into collapsed groups when double-clicking the group.

Reviewers

@DynamoDS/eidos
@jasonstratton
@johnpierson

FYIs

@dnenov

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9321

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant