DYN-9321: Prevent adding CBN into collapsed annotation on double-click - #17282
Open
ivaylo-matov wants to merge 1 commit into
Conversation
plus regression test
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9321
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
This is a small PR to address DYN-9321
Fixes a bug where double-clicking a collapsed annotation would create a visible
CodeBlocknode that nevertheless became part of the collapsed group's model (causing layout/visibility/boundary glitches).Now double-clicking an annotation still creates a
CodeBlocknode, but the node is only added to the annotation when the annotation is expanded (aligned with drag-to-group behavior).Changes
WorkspaceViewModel.HandleAnnotationDoubleClickensure newly created node is added to the annotation only when annotation.IsExpandedBefore:
After:
Declarations
Check these if you believe they are true
Release Notes
Prevent newly created Code Block nodes from being added into collapsed groups when double-clicking the group.
Reviewers
@DynamoDS/eidos
@jasonstratton
@johnpierson
FYIs
@dnenov