fix(api): configurable body size limits for OpenAPI catch-all route - #5048
Open
narcisonunez wants to merge 3 commits into
Open
fix(api): configurable body size limits for OpenAPI catch-all route#5048narcisonunez wants to merge 3 commits into
narcisonunez wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Application.dropDeployment 500s on any multipart upload today, since Next's default bodyParser consumes the stream before getMultipartBody can read it. Disabling bodyParser fixes that but drops trpc-openapi's JSON body limit to its internal 100KB default (no maxBodySize passed), breaking compose.import/processTemplate/previewTemplate on anything over 100KB. Multipart uploads also end up with no cap at all, since getMultipartBody ignores maxBodySize.
Pass
maxBodySizeexplicitly and add aContent-Lengthguard for multipart. Both configurable viaOPENAPI_MAX_JSON_BODY_SIZE/OPENAPI_MAX_UPLOAD_SIZE(default 10mb / 1gb).Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4236, #4315
Screenshots (if applicable)
Greptile Summary
The PR makes OpenAPI request-body limits configurable while preserving raw multipart streams.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Reviews (3): Last reviewed commit: "fix(api): reject non-integer body size e..." | Re-trigger Greptile