Skip to content

fix: preserve raw flag when resuming logs - #439

Draft
liyimil wants to merge 1 commit into
unjs:mainfrom
liyimil:agent/preserve-raw-log-queue
Draft

fix: preserve raw flag when resuming logs#439
liyimil wants to merge 1 commit into
unjs:mainfrom
liyimil:agent/preserve-raw-log-queue

Conversation

@liyimil

@liyimil liyimil commented Jul 22, 2026

Copy link
Copy Markdown

What changed

  • forward the queued isRaw flag when resumeLogs() replays paused logs
  • add regression coverage comparing immediate and queued raw log arguments

Why

_wrapLogFn stores isRaw as the fourth queue item, but resumeLogs() previously passed only the first three values to _logFn. A raw object queued during pauseLogs() was therefore reinterpreted as a structured log object instead of remaining a raw argument.

Fixes #438.

Checks

  • ESLint across the repository
  • Prettier check for src, examples, and test
  • Vitest with V8 coverage: 4 tests passed
  • unbuild production build

Prepared with Codex assistance; the issue, implementation, diff, and checks were reviewed locally.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 92a3dc41-486e-46b2-8681-ad228a7e6424

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resumeLogs drops isRaw flag, mangling .raw() calls queued during pause

1 participant