Zero-copy ArrayBuffer for Java TM - #57897
Draft
paradowstack wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Android TurboModules always copied JS
ArrayBufferarguments into a Java-owned directByteBuffer, so sync in-place mutation was impossible.This matches the iOS zero-copy path: sync calls alias JS bytes (or retain native-backed buffers); async
void/Promisecalls still copy. Returning the same aliased argument reuses its backing store.Changelog:
[ANDROID] [ADDED] - Zero-copy JS→Native
ArrayBufferfor synchronous TurboModule callsTest Plan: