Parent class method always throws, child overrides and returns—return type mismatch #14898
|
I have the following setup: abstract class Foo
{
/**
* @return never
*/
public function bar()
{
throw new Exception();
}
}
class Bar extends Foo
{
#[\Override]
public function bar()
{
return 'baz';
}
}I firmly believe, that the annotation of |
Replies: 1 comment 4 replies
|
They don't fit together. Return types must be covariant, parameter type contravariant. The contract of Foo::bar is that it always throws. Bar::bar violates that. |
|
So, you are saying, it is impossible to say |
|
You can say it |
|
But |
|
your initial example is not valid php, see https://3v4l.org/c44pJ#veol its not a PHPStan limitation |
They don't fit together. Return types must be covariant, parameter type contravariant.
The contract of Foo::bar is that it always throws. Bar::bar violates that.