Improved pull request "Files Changed" experience feedback #163932
Replies: 3187 comments 1315 replies
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
|
It doesn't always seem to remember if hide whitespace was turned on. |
|
Related product feedback: prefer rich/rendered diff by default for supported file types — https://github.com/orgs/community/discussions/203750 |
|
Preferences have to be browser-local, instead enabling split mode also affects when browsing PRs in a mobile web browser. The current split mode in a mobile web rendered ugly, as its width constrained to the device width |
|
I really dislike the new review comment experience. Frustratingly, when Copilot makes suggestions on a diff you can only access the "Add suggestion to batch" option from the new experience. I have no idea why this is since that button is available on human suggestions. So I find myself having to switch back and forwards between the two experiences, which is not a good experience. I think that the new review comment experience doesn't work for me because you seem to have to expand each comment individually. It's also easy to miss a comment. |
|
|
My comments keep disappearing from the |
This comment was marked as spam.
This comment was marked as spam.
|
Conversation view has so many issues; Cannot add replies to the comment if it's the first reply when using the right side panel for conversation view. Clicking the message doesn't always scroll directly to the message and then can cause Z index layering issues. |
|
The new view is too minimalist to the point where it's difficult to see things I've already commented on. |
|
The new Files Changed experience looks much cleaner overall. 👍 One thing I’d really like to see improved is the comment workflow. When a comment is from an older version of the code, it can take several steps to get back to the current code and check whether the issue was actually fixed. Having a quick way to compare the commented version vs. the current version would make large PR reviews much easier. |
|
I believe there's a bug when applying a batch of suggested changes on Windows. In a repo with .gitattributes including With the new experience, on Windows 11, if I add multiple PR suggestions to a batch and apply that batch, the resulting commit contains CRLF in the blob (on each of the changed lines). Instead, I expect them to be converted to LF, as though someone had committed the changes as usual. With the old experience, I can't reproduce this problem. Note batching seems to be required; I didn't see this when applying a single suggestion. |
|
It looks like in the new experience, there is no way any more to see which releases contain a commit. |
|
I’ve been trying the new Files changed experience and the ability to comment on unchanged lines is probably the improvement I’ve found most useful. The pending comments and draft saving are also nice touches, especially when reviewing larger PRs. It feels like the overall workflow is becoming much smoother without changing the core review process too much. |
|
It would be great if I could enable the "one file at a time" in code reviews as a permanent setting and not only when there are huge changes. |



















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
All reactions