#3570 renamed StorageClient to StorageBackend. The load signal that polls it kept the old
vocabulary, to the point where client_load_signal.ts:63 reads private client?: StorageBackend;.
Misnamed:
LoadSignalsOptions.client — autoscaling/snapshotter.ts:46ClientLoadSignal / ClientLoadSignalOptions — client_load_signal.ts:55, :24- the reserved signal name
'clientInfo' — client_load_signal.ts:56
SystemInfo.clientInfo — system_status.ts:14, option-key map :111, placeholder :228ClientInfo (system_status.ts:87-91) is not client-specific at all — it is the per-signal
overload verdict used by memInfo, cpuInfo, eventLoopInfo and loadSignalInfo too.
LoadSignalInfo would match the bag it already backs.
Worth deciding: storageBackend vs rateLimit. The signal counts HTTP 429s
(client_load_signal.ts:44-46), so rateLimit describes what is measured, reads better beside
memory/cpu/eventLoop, and avoids storageBackendInfo.
#3570 renamed
StorageClienttoStorageBackend. The load signal that polls it kept the oldvocabulary, to the point where
client_load_signal.ts:63readsprivate client?: StorageBackend;.Misnamed:
LoadSignalsOptions.client—autoscaling/snapshotter.ts:46ClientLoadSignal/ClientLoadSignalOptions—client_load_signal.ts:55,:24'clientInfo'—client_load_signal.ts:56SystemInfo.clientInfo—system_status.ts:14, option-key map:111, placeholder:228ClientInfo(system_status.ts:87-91) is not client-specific at all — it is the per-signaloverload verdict used by
memInfo,cpuInfo,eventLoopInfoandloadSignalInfotoo.LoadSignalInfowould match the bag it already backs.Worth deciding:
storageBackendvsrateLimit. The signal counts HTTP 429s(
client_load_signal.ts:44-46), sorateLimitdescribes what is measured, reads better besidememory/cpu/eventLoop, and avoidsstorageBackendInfo.